Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tkn triggerbinding describe command #912

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Add tkn triggerbinding describe command #912

merged 1 commit into from
Apr 21, 2020

Conversation

savitaashture
Copy link
Contributor

@savitaashture savitaashture commented Apr 17, 2020 •
edited
Loading

Part of #594

Signed-off-by: Savita Ashture [email protected]

Changes

Add Describe Command for TriggerBinding

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes tests (if functionality changed/added)
  • Run the code checkers with make check
  • Regenerate the manpages, docs and go formatting with make generated
  • Commit messages follow commit message best practices

See the contribution guide
for more details.

Release Notes

Add tkn tb desc command to describe a TriggerBinding

@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 17, 2020
danielhelfand
danielhelfand suggested changes Apr 18, 2020
View reviewed changes
pkg/cmd/triggerbinding/describe_test.go Outdated Show resolved Hide resolved
pkg/cmd/triggerbinding/describe_test.go Outdated Show resolved Hide resolved
pkg/cmd/triggerbinding/describe_test.go Show resolved Hide resolved
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 18, 2020
@piyush-garg
Copy link
Contributor

/lgtm

Can you please squash the commits?

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2020
@savitaashture savitaashture mentioned this pull request Apr 18, 2020
Closed
3 tasks
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 18, 2020
@savitaashture
Copy link
Contributor Author

/lgtm

Can you please squash the commits?

Done

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 20, 2020
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 21, 2020 •
edited
Loading

CLA Check
The committers are authorized under a signed CLA.

@pradeepitm12
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@tekton-robot tekton-robot merged commit 62365e4 into tektoncd:master Apr 21, 2020
@danielhelfand danielhelfand mentioned this pull request Apr 21, 2020
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepitm12 pradeepitm12 pradeepitm12 left review comments

@piyush-garg piyush-garg piyush-garg left review comments

@danielhelfand danielhelfand danielhelfand approved these changes

@chmouel chmouel Awaiting requested review from chmouel

Assignees

@piyush-garg piyush-garg

@pradeepitm12 pradeepitm12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@savitaashture @piyush-garg @tekton-robot @pradeepitm12 @danielhelfand @googlebot